Skip to content

docs: fix workflow-deep-dive repo mislabel and validation checklist gap - #32

Merged
smartwatermelon merged 1 commit into
mainfrom
claude/docs-fix-workflow-deep-dive-and-checklist-2508
Aug 3, 2026
Merged

docs: fix workflow-deep-dive repo mislabel and validation checklist gap#32
smartwatermelon merged 1 commit into
mainfrom
claude/docs-fix-workflow-deep-dive-and-checklist-2508

Conversation

@smartwatermelon

Copy link
Copy Markdown
Owner

Summary

  • Fixes issue WORKFLOW-DEEP-DIVE.md mislabels claude-wrapper as "this repo" #25: docs/WORKFLOW-DEEP-DIVE.md Layer 6 (GitHub Actions) mislabeled the source of claude-code-review.yml/claude.yml as "(this repo)". Verified via gh api against smartwatermelon/claude-wrapper and smartwatermelon/dev-env that these workflow files (as named/described in the doc) actually live in claude-wrapper, not dev-envdev-env only has claude-blocking-review.yml and dependabot-auto-merge.yml. Corrected all five occurrences of the same mislabel (lines ~60, ~64, ~310, ~486, ~595) to attribute them to smartwatermelon/claude-wrapper.
  • Fixes issue Add post-commit hook commit-hash reliability item to validation checklist #18: Added the missing dotfiles#29 (post-commit hook commit-hash mismatch fix) item to the Phase 2 validation checklist's Reliability section in docs/plans/2026-04-02-phase2-local-whole-codebase-review.md. This fix was implemented and logged in the Implementation log (~line 188) but never made it into the checklist. Added a one-line note clarifying the item was added 2026-08-03, after the original 2026-04-10 validation window closed, so it's not misread as having been part of the live validation.

Test plan

  • Verified actual workflow file locations via gh api repos/smartwatermelon/{claude-wrapper,dev-env}/contents/.github/workflows
  • Confirmed dev-env has no claude-code-review.yml or claude.yml; claude-wrapper has claude-blocking-review.yml and claude.yml matching the doc's described behavior
  • Manual diff review of both files (docs-only repo, no build/test/lint)
  • Note: this repo's .git/config has a local core.hookspath override pointing at its own (mostly empty) .git/hooks, which bypassed the global pre-commit review hooks for this commit — pre-existing repo-local config issue, out of scope for this PR, flagging for awareness.

Closes #25
Closes #18

https://claude.ai/code/session_01SsnvQEpWgMxcRocq8bBVSE

…hecklist item

Layer 6 (GitHub Actions) in WORKFLOW-DEEP-DIVE.md mislabeled
claude-wrapper's workflow files as "(this repo)" — verified via gh api
that claude-code-review.yml/claude.yml as described live in
smartwatermelon/claude-wrapper, not dev-env (dev-env only has
claude-blocking-review.yml). Corrected all five occurrences of this
mislabel (lines ~60, ~64, ~310, ~486, ~595).

Also added the missing dotfiles#29 (post-commit hash mismatch fix)
item to the Phase 2 validation checklist's Reliability section, per
issue #18 — it was implemented and logged but never added to the
checklist. Added a note clarifying this was added retroactively after
the 2026-04-10 validation window closed.

Closes #25, closes #18

Claude-Session: https://claude.ai/code/session_01SsnvQEpWgMxcRocq8bBVSE
@smartwatermelon
smartwatermelon merged commit 01f515c into main Aug 3, 2026
2 checks passed
@smartwatermelon
smartwatermelon deleted the claude/docs-fix-workflow-deep-dive-and-checklist-2508 branch August 3, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WORKFLOW-DEEP-DIVE.md mislabels claude-wrapper as "this repo" Add post-commit hook commit-hash reliability item to validation checklist

1 participant